Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade React from 372ec00c-20241209 to 4b7d4530-20241218 #74106

Closed
wants to merge 6 commits into from
Closed

Upgrade React from 372ec00c-20241209 to 4b7d4530-20241218 #74106

wants to merge 6 commits into from

Conversation

vercel-release-bot
Copy link
Collaborator

@ijjk ijjk added CI approved Approve running CI for fork type: next labels Dec 18, 2024
@ztanner ztanner changed the base branch from canary to next-15-0 December 18, 2024 23:06
@ztanner ztanner changed the base branch from next-15-0 to canary December 18, 2024 23:07
@ijjk
Copy link
Member

ijjk commented Dec 18, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.0.0-rc-4b7d4530-20241218 Change
buildDuration 32.9s 29.2s N/A
buildDurationCached 29.8s 25.7s N/A
nodeModulesSize 416 MB 416 MB ⚠️ +30 kB
nextStartRea..uration (ms) 765ms 665ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js update/react/19.0.0-rc-4b7d4530-20241218 Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update/react/19.0.0-rc-4b7d4530-20241218 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js update/react/19.0.0-rc-4b7d4530-20241218 Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js update/react/19.0.0-rc-4b7d4530-20241218 Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js update/react/19.0.0-rc-4b7d4530-20241218 Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 538 B ✓
withRouter.html gzip 519 B 521 B N/A
Overall change 538 B 538 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js update/react/19.0.0-rc-4b7d4530-20241218 Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 205 kB 205 kB ✓
Overall change 205 kB 205 kB ✓
Middleware size
vercel/next.js canary vercel/next.js update/react/19.0.0-rc-4b7d4530-20241218 Change
middleware-b..fest.js gzip 668 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.0.0-rc-4b7d4530-20241218 Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 356 kB 356 kB ⚠️ +179 B
app-page-exp..prod.js gzip 129 kB 129 kB N/A
app-page-tur..prod.js gzip 142 kB 142 kB ⚠️ +119 B
app-page-tur..prod.js gzip 137 kB 137 kB ⚠️ +120 B
app-page.run...dev.js gzip 347 kB 347 kB ⚠️ +174 B
app-page.run..prod.js gzip 125 kB 125 kB N/A
app-route-ex...dev.js gzip 37.5 kB 37.5 kB ✓
app-route-ex..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.3 kB 25.3 kB N/A
app-route.ru...dev.js gzip 39.1 kB 39.1 kB N/A
app-route.ru..prod.js gzip 25.3 kB 25.3 kB N/A
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 1.12 MB 1.12 MB ⚠️ +592 B
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.0.0-rc-4b7d4530-20241218 Change
0.pack gzip 2.08 MB 2.08 MB ⚠️ +778 B
index.pack gzip 73.7 kB 73.8 kB ⚠️ +152 B
Overall change 2.16 MB 2.16 MB ⚠️ +930 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js 
failed to diff
Commit: 3862306

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-dom@0.0.0-experimental-4b7d4530-20241218 None 0 8.31 MB fb, gnoff, react-bot, ...2 more
npm/react-dom@19.0.0-rc-4b7d4530-20241218 None 0 6.38 MB fb, gnoff, react-bot, ...2 more
npm/react-is@19.0.0-rc-4b7d4530-20241218 environment 0 13.6 kB fb, gnoff, react-bot, ...1 more
npm/react-server-dom-turbopack@0.0.0-experimental-4b7d4530-20241218 None +1 1.37 MB acdlite, gnoff, react-bot
npm/react-server-dom-turbopack@19.0.0-rc-4b7d4530-20241218 None +1 1.27 MB acdlite, gnoff, react-bot
npm/react-server-dom-webpack@0.0.0-experimental-4b7d4530-20241218 None +1 1.84 MB acdlite, brianvaughn, gaearon, ...2 more
npm/react-server-dom-webpack@19.0.0-rc-4b7d4530-20241218 None +1 1.71 MB acdlite, brianvaughn, gaearon, ...2 more
npm/react@19.0.0-rc-4b7d4530-20241218 None 0 238 kB fb, gnoff, react-bot, ...1 more
npm/scheduler@0.25.0-rc-4b7d4530-20241218 None 0 84.2 kB react-bot

🚮 Removed packages: npm/react-dom@0.0.0-experimental-372ec00c-20241209, npm/react-dom@19.0.0-rc-372ec00c-20241209, npm/react-is@19.0.0-rc-372ec00c-20241209, npm/react-server-dom-turbopack@0.0.0-experimental-372ec00c-20241209, npm/react-server-dom-turbopack@19.0.0-rc-372ec00c-20241209, npm/react-server-dom-webpack@0.0.0-experimental-372ec00c-20241209, npm/react-server-dom-webpack@19.0.0-rc-372ec00c-20241209, npm/react@19.0.0-rc-372ec00c-20241209, npm/scheduler@0.25.0-rc-372ec00c-20241209

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Dec 18, 2024

Failing test suites

Commit: 3862306

pnpm test-dev test/e2e/socket-io/index.test.js

  • socket-io > should support socket.io without falling back to polling
Expand output

● socket-io › should support socket.io without falling back to polling

TIMED OUT: /hello world/



undefined

  731 |
  732 |   if (hardError) {
> 733 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  734 |   }
  735 |   return false
  736 | }

  at check (lib/next-test-utils.ts:733:11)
  at Object.<anonymous> (e2e/socket-io/index.test.js:31:5)

Read more about building and testing Next.js in contributing.md.

@eps1lon eps1lon assigned ztanner and unassigned eps1lon Dec 18, 2024
eps1lon
eps1lon requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should target a backport branch

@ztanner ztanner closed this Dec 19, 2024
@eps1lon eps1lon deleted the update/react/19.0.0-rc-4b7d4530-20241218 branch December 19, 2024 19:57
@github-actions github-actions bot added the locked label Jan 3, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eps1lon eps1lon eps1lon requested changes

Assignees

@ztanner ztanner

Labels
CI approved Approve running CI for fork locked type: next type: react-sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vercel-release-bot @ijjk @eps1lon @ztanner